-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Test Cases #24
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 87.61% 90.47% +2.85%
==========================================
Files 7 7
Lines 105 105
==========================================
+ Hits 92 95 +3
+ Misses 13 10 -3
☔ View full report in Codecov by Sentry. |
@ninamiolane Requesting your review. Docs deployment failed, but I think it has nothing to do with the code changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! Very important to test this module indeed. I have made one minor, yet very important, comment on the naming of test functions.
Why is the docs deployment failing?
@ninamiolane Have made the requested changes. |
@ninamiolane |
I see for the docs issue! Hm, let's just try to merge the PR then 🤞 |
Adding test cases for the neighborhood module.